Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added native token top-up and withdraw functionality in VRFv2PlusSubscriptionManager contract. #2123

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added native token top-up and withdraw functionality in VRFv2PlusSubscriptionManager contract. #2123

wants to merge 3 commits into from

Conversation

SyedAsadKazmi
Copy link
Contributor

Some devs are asking for this functionality, as can be seen from this Eth-StackExchange post, so I've added thetopUpSubscriptionWithNativeToken and withdrawNativeToken functions to support the same.

Added topUpSubscriptionWithNativeToken() and withdrawNativeToken() fu…
e5c3bc9 
…nctions in samples/VRF/v2-5/SubscriptionManager.sol file
@vercel Vercel
Copy link

vercel bot commented Oct 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview Dec 19, 2024 3:38pm

@QingyangKong
Copy link
Contributor

Hi @SyedAsadKazmi , thanks for the contribution. Since this PR is to help users to fund the vrf 2.5 subscription with native tokens, I think it might be a good idea that you can also add a new function to allow them to request randomness with native payment.

For now, although users can fund the subscription with native tokens, there is no function in the contract for them to request randomness with native balance.

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024

Someone is attempting to deploy a commit to the Chainlink Labs Team on Vercel.

A member of the Team first needs to authorize it.

@SyedAsadKazmi
Copy link
Contributor Author

SyedAsadKazmi commented Dec 13, 2024 •
edited
Loading

Hi @SyedAsadKazmi , thanks for the contribution. Since this PR is to help users to fund the vrf 2.5 subscription with native tokens, I think it might be a good idea that you can also add a new function to allow them to request randomness with native payment.

For now, although users can fund the subscription with native tokens, there is no function in the contract for them to request randomness with native balance.

Hello @QingyangKong,

Thanks for the feedback. I've added the enableNativePayment argument to the requestRandomWords() function. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QingyangKong QingyangKong QingyangKong approved these changes

@aelmanaa aelmanaa Awaiting requested review from aelmanaa aelmanaa is a code owner

@thedriftofwords thedriftofwords Awaiting requested review from thedriftofwords thedriftofwords is a code owner

@khadni khadni Awaiting requested review from khadni khadni is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SyedAsadKazmi @QingyangKong @thedriftofwords